jebbs/data-extracter-extesion
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

improve error handling

Browse Source
This commit is contained in:
jebbs
2018-09-28 16:20:52 +08:00
parent 3f49544b1c
commit 242474085a
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
scripts/extract.js
View File

@ -153,7 +153,8 @@ function sendMessage(tab, req, cond, interval) {
console.log("request for", req.from); console.log("request for", req.from);
let tabAvailable = await getTabByID(tab.id); let tabAvailable = await getTabByID(tab.id);
if (!tabAvailable) { if (!tabAvailable) {
throw new Error("Task interupted due to the target tab is closed."); reject("Task interupted due to the target tab is closed.");
return;
} }
chrome.tabs.sendMessage(tab.id, req, r => { chrome.tabs.sendMessage(tab.id, req, r => {
@ -183,6 +184,7 @@ async function getActiveTab(currentWindow) {
async function getTabByID(id) { async function getTabByID(id) {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
chrome.tabs.get(id, function (tab) { chrome.tabs.get(id, function (tab) {
chrome.runtime.lastError;
resolve(tab); resolve(tab);
}) })
}) })

4
scripts/extractor.js
View File

@ -47,7 +47,7 @@ class Extractor {
this._results[this._tasks[this._tasks.length - 1]] = result; this._results[this._tasks[this._tasks.length - 1]] = result;
this.save(); this.save();
} }
); ).catch(err => console.log(err));
} }
/** /**
* restart from specified task, but don't restart the previous tasks. * restart from specified task, but don't restart the previous tasks.
@ -76,7 +76,7 @@ class Extractor {
this._results[this._tasks[this._tasks.length - 1]] = result; this._results[this._tasks[this._tasks.length - 1]] = result;
this.save(); this.save();
} }
); ).catch(err => console.log(err));
} }
/** /**
* Save result of a task * Save result of a task